This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
Update Node types and TypeScript #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Node types to latest version 12 to reflect the dropping of Node 8 and Node 10 from support. This required TypeScript to be updated since TypeScript < 3.7 is not support starting from @types/node v12.20.12 (ref. DefinitelyTyped/DefinitelyTyped#55430). The chosen TypeScript version was the latest 3.9 version. The update to TypeScript 4.x can be done as a followup. Updating the two libraries required some type changes in the implementation, notably the possibly breaking change of changing the type of `ServiceClientRequestOptions.query` from `object | undefined` to `ParsedUrlQueryInput | undefined`, which is more specific about the possible query parameter types.
|
👍 |
1 similar comment
|
👍 |
|
👍 |
|
It looks like the package version hasn't been updated in some time, should we bump it as part of this PR? |
|
👍 |
Comment on lines
-528
to
-542
| const { | ||
| port, | ||
| protocol, | ||
| query, | ||
| hostname = "", | ||
| pathname = "/" | ||
| } = url.parse(optionsOrUrl, true); | ||
| const { port, protocol, query, hostname, pathname } = url.parse( | ||
| optionsOrUrl, | ||
| true | ||
| ); | ||
| options = { | ||
| hostname, | ||
| hostname: hostname || "", | ||
| defaultRequestOptions: { | ||
| port, | ||
| protocol, | ||
| query, | ||
| // pathname will be overwritten in actual usage, we just guarantee a sane default | ||
| pathname |
There was a problem hiding this comment.
Is there any issue with the defaults not working with deconstruction?
ponimas
reviewed
May 13, 2022
| options = { | ||
| hostname, | ||
| hostname: hostname || "", |
There was a problem hiding this comment.
Suggested change
| hostname: hostname || "", | |
| hostname: hostname ?? "", |
| defaultRequestOptions: { | ||
| port, | ||
| protocol, | ||
| query, | ||
| // pathname will be overwritten in actual usage, we just guarantee a sane default | ||
| pathname | ||
| pathname: pathname || "/" |
There was a problem hiding this comment.
Suggested change
| pathname: pathname || "/" | |
| pathname: pathname ?? "/" |
Comment on lines
+238
to
+240
| if (requestObject.socket != null) { | ||
| requestObject.socket.destroy(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (requestObject.socket != null) { | |
| requestObject.socket.destroy(); | |
| } | |
| requestObject.socket?.destroy(); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Node types to latest v16 and TypeScript to latest v3
Updating the two libraries required some type changes in the
implementation, notably the possibly breaking change of changing the
type of
ServiceClientRequestOptions.queryfromobject | undefinedtoParsedUrlQueryInput | undefined, which is more specific about thepossible query parameter types. Clients of the library who defined earlier
own types to structure query parameters, need to make sure the types extend
ParsedUrlQueryInput